feat: add configurable yaw-offset for display entities - #39
Open
VitzS7 wants to merge 1 commit into
Open
Conversation
Rotação extra de yaw (em graus) somada às display entities no Bedrock. 180 = virar para o outro lado. Lida no ConfigManager e aplicada no bedrockRotation() do ItemDisplayEntity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable
yaw-offsetoption (degrees) that is added to the yaw of display entities on Bedrock.Why
Some setups need display entities to face the other way (or be rotated by an arbitrary amount) without editing each entity. A global
yaw-offset: 180.0flips them all to face the opposite direction.Changes
config.yml: newgeneral.yaw-offsetoption (default180.0) with an explanatory comment.ConfigManager: loadsgeneral.yaw-offsetinto ayawOffsetfield with gettergetYawOffset().ItemDisplayEntity#bedrockRotation(): addsgetYawOffset()to the computed yaw before wrapping to degrees.Test plan
./gradlew build -x testgetYawOffset()methodyaw-offset: 180.0flips item display entities to face the opposite way on Bedrock